Skip to content

feat(settings): add option to use 24hr clock (#112) - #116

Closed
MIR-2004 wants to merge 1 commit into
Gsync:mainfrom
MIR-2004:feat/24hr-clock-option
Closed

feat(settings): add option to use 24hr clock (#112)#116
MIR-2004 wants to merge 1 commit into
Gsync:mainfrom
MIR-2004:feat/24hr-clock-option

Conversation

@MIR-2004

@MIR-2004 MIR-2004 commented Sep 7, 2026

Copy link
Copy Markdown

Description

Closes #112

This PR adds an option in the Display Settings to toggle between a 12-hour (AM/PM) and 24-hour clock format. The selected setting is reflected across the entire application:

  • Display Settings: Added a Clock Format section (12-hour vs 24-hour options).
  • TimePicker: Supports 24-hour mode (00–23 hours, 00–59 minutes, hiding the AM/PM column) with 5-minute step shifting.
  • Activity Form & Table: Form initializes with default times matching the chosen format, and activity start/end times in the table render using the selected clock.
  • Validation: Updated AddActivityFormSchema and combineDateAndTime helper to parse and validate both 12h and 24h time strings.
  • Context: Added UserSettingsContext for reactive dashboard-wide updates upon saving settings.

Testing

  • Added unit tests for 12h and 24h mode in __tests__/TimePicker.spec.tsx and __tests__/clockFormat.spec.ts.
  • Ran full test suite (2575 tests passing).
  • Verified production build completes successfully (npm run build).

@MIR-2004
feat(settings): add option to use 24hr clock (Gsync#112)
97f216f 
- add 12h/24h clock format toggle to display settings
- support 24-hour mode in TimePicker component
- update activity form schema and date-time utils to parse and validate both formats
- format activity tables and task timestamps according to user clock preference
- add UserSettingsContext provider and hooks for clock format state
- add unit tests for clock format utilities and TimePicker 24h mode
@Gsync

Gsync commented Sep 19, 2026

Copy link
Copy Markdown
Owner

I'm going to close this one — not because the request in #112 is wrong, but because the timing and the shape aren't right yet.

Time display settings aren't on the roadmap yet. Timezone support is coming, and that will have to define how times are stored and rendered app-wide. A clock-format preference added now would be reworked as soon as that lands, so I'd rather do both together and get one coherent model.

The change has side effects for users who never opt in. ActivitiesTable.tsx:110 swaps the locale-aware format(..., "p") for a hardcoded "hh:mm a", so every existing user's activity times go from 2:30 PM to 02:30 PM and non-en locales lose their own short-time form.

A failed settings read silently resets the preference. In DisplaySettings.tsx:64 (and the catch at :79) the form resets with a hardcoded clockFormat: "12h". The user then changes only the theme, saves, and their stored 24h is overwritten.

Save writes twice, and the second write races. onSubmit awaits updateDisplaySettings(...) and then calls updateDisplay(...), which calls it again — unawaited. Two consecutive saves can land out of order and persist the older value.

Coverage is partial. The setting reaches 3 surfaces; Automations, Run History, Match Details, Notes, Reviews and Data Settings are still hardcoded 12-hour, so a 24h user keeps seeing 2:30 PM on most of the app.

There's also an unrelated edit in PdfPreviewPane.tsx:136 making destroy optional, which isn't needed for this change.

Thanks for the contribution — I'll keep #112 open and fold clock format into the timezone work.

Reviewed with Claude Opus 5.

@Gsync Gsync closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request : Add an option to use 24hr clock

2 participants

@MIR-2004 @Gsync